Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update dependency @secretlint/secretlint-rule-preset-recommend to v7 - autoclosed #1449

Closed
wants to merge 1 commit into from
Closed

chore(deps): update dependency @secretlint/secretlint-rule-preset-recommend to v7 - autoclosed #1449

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 2, 2023 •
edited
Loading

Mend Renovate logo banner

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@secretlint/secretlint-rule-preset-recommend (source) ^3.1.0 -> ^7.0.0 age adoption passing confidence

Release Notes

secretlint/secretlint (@​secretlint/secretlint-rule-preset-recommend)

v7.1.0

Compare Source

What's Changed

Features

We plan to include this rule into preset in secretlint v8 #​680

Maintenance
Dependency Updates
Other Changes

New Contributors

Full Changelog: secretlint/secretlint@v7.0.8...7.1.0

v7.0.8

Compare Source

What's Changed

Bug Fixes
Refactoring
Dependency Updates
Other Changes

New Contributors

Full Changelog: secretlint/secretlint@v7.0.7...7.0.8

v7.0.7

Compare Source

What's Changed
Refactoring

Full Changelog: secretlint/secretlint@v7.0.6...7.0.7

v7.0.6

Compare Source

What's Changed
Bug Fixes

Full Changelog: secretlint/secretlint@v7.0.5...7.0.6

v7.0.5

Compare Source

What's Changed
Bug Fixes
Other Changes

Full Changelog: secretlint/secretlint@v7.0.4...7.0.5

v7.0.4

Compare Source

What's Changed

This release includes various fixes for Windows.

Bug Fixes
CI
Dependency Updates

Full Changelog: secretlint/secretlint@v7.0.3...v7.0.4

v7.0.3

Compare Source

What's Changed
Bug Fixes
Testing
Dependency Updates
New Contributors

Full Changelog: secretlint/secretlint@v7.0.2...7.0.3

v7.0.2

Compare Source

What's Changed
Bug Fixes

Full Changelog: secretlint/secretlint@v7.0.1...7.0.2

v7.0.1

Compare Source

What's Changed
Bug Fixes
Dependency Updates
New Contributors

Full Changelog: secretlint/secretlint@v7.0.0...7.0.1

v7.0.0

Compare Source

This release convert almost secretlint packages to Pure ESM 🎉

Breaking Changes
  • Require Node.js 18+ #​538
    • package code format is ES2022
  • Update Docker image based on Node.js 18 #​468
  • Update Exit Status #​547
    • Secretlint exits with the following values
    • 0: Linting succeeded, no errors found
    • 1: Linting failed, errors found
    • 2: Unexpected error occurred, fatal error
    • Previously, these values are not defined
  • Add new "json" formatter for secretlint #​45
    • output format is changed from old "json" formatter
  • Convert packages to Pure ESM package
    • PRs: #​527 #​530
    • If your scripts are CommonJS, you need to dynamic import import("@​secretlint/core").
    • For command line/Docker user, No change anything!
  • Convert @secretlint/types to dual package
  • @secretlint/tester is migrated to ESM, But we can load it using dynamic import from CJS
    • @secretlint/tester uses node:test instead of Mocha
    • Also, Support URL object in snapshotDirectory option.

It means that you can still write your rule in CommonJS.
You can migrate your snapshot testing code to secretlint v7 by following:

CommonJS Edition:

- import { snapshot } from "@​secretlint/tester";
import path from "path";
import { creator as rule } from "../src/index";
+ import test from "node:test";
- describe("@​secretlint/secretlint-rule-example", () => {
+ test("@​secretlint/secretlint-rule-example", async (t) => {
+      const snapshot = (await import("@​secretlint/tester")).snapshot;
-      snapshot({
+      await snapshot({
          defaultConfig: {
              rules: [
                  {
                      id: "@​secretlint/secretlint-rule-preset-canary",
                      rule,
                      rules: [],
                      options: {},
                  },
              ],
          },
          updateSnapshot: !!process.env.UPDATE_SNAPSHOT,
          snapshotDirectory: path.join(__dirname, "snapshots"),
      }).forEach((name, test) => {
-          it(name, async function () {
+          return it(name, async (context) => {
              const status = await test();
              if (status === "skip") {
-                  this.skip();
+                  context.skip();
              }
          });
      });
  });

Of course, you can write test in ESM and rule.

import test from "node:test";
import { snapshot } "@​secretlint/teter";
import { creator as rule } from "../src/index.js";
test("@​secretlint/secretlint-rule-example", async (t) => {
    return snapshot({
        defaultConfig: {
            rules: [
                {
                    id: "@​secretlint/secretlint-rule-example",
                    rule,
                    options: {},
                },
            ],
        },
        updateSnapshot: !!process.env.UPDATE_SNAPSHOT,
        snapshotDirectory: new URL("snapshots", import.meta.url),
    }).forEach((name, test) => {
        return t.test(name, async (context) => {
            const status = await test();
            if (status === "skip") {
                context.skip();
            }
        });
    });
});

And run tests via Node.js Test runner

$ node --test test/index.test.js
##### or
$ node --loader ts-node/esm --test test/index.test.ts

For more details, see https://github.com/secretlint/secretlint/blob/master/docs/secretlint-rule.md and Node.js Test runner

Change Logs
Breaking Changes
Bug Fixes
Documentation
Dependency Updates
Other Changes

Full Changelog: secretlint/secretlint@v6.2.4...7.0.0

v6.2.4

Compare Source

What's Changed
Security Fixes

It will resolve vulnerability issues with semver.

Dependency Updates

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the Type: Dependency Dependencies fixes label Jul 2, 2023
@renovate renovate bot force-pushed the renovate/secretlint-secretlint-rule-preset-recommend-7.x branch from 9f85fde to 2d51c81 Compare July 7, 2023 18:17
@renovate renovate bot force-pushed the renovate/secretlint-secretlint-rule-preset-recommend-7.x branch 2 times, most recently from a9b8e1a to ea05e00 Compare August 21, 2023 11:35
@renovate renovate bot force-pushed the renovate/secretlint-secretlint-rule-preset-recommend-7.x branch from ea05e00 to ce917a7 Compare August 28, 2023 09:38
@renovate renovate bot changed the title chore(deps): update dependency @secretlint/secretlint-rule-preset-recommend to v7 chore(deps): update dependency @secretlint/secretlint-rule-preset-recommend to v7 - autoclosed Nov 29, 2023
@renovate renovate bot closed this Nov 29, 2023
@renovate renovate bot deleted the renovate/secretlint-secretlint-rule-preset-recommend-7.x branch November 29, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Dependency Dependencies fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants