Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe it's time to define & test the behaviour with repeated indices. This fixes:
sum(A, dims=:i)
to use the first dimension named:i
, as it already did, andA[i=1]
is an error if more than one dimension is named:i
. Previously it fixed all such dimensions.The one exception I can think of is that, for a
Diagonal
matrix, it may make sense to index both dimensions together. But maybe I have overlooked other uses?The indexing change did not break any tests. But may still count as a breaking change, not sure.