Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI serializer: Fix imprint and journal format #1405

Closed
wants to merge 1 commit into from
Closed

UI serializer: Fix imprint and journal format #1405

wants to merge 1 commit into from

Conversation

jrcastro2
Copy link
Contributor

tmorrell
tmorrell reviewed Aug 9, 2023
View reviewed changes
invenio_rdm_records/resources/serializers/ui/schema.py
publication_date_edtf = parse_edtf(publication_date).lower_strict() if publication_date else None
publication_date_formatted = f" ({publication_date_edtf.tm_year})" if publication_date_edtf else None

issn = f" no. {journal_issn}" if journal_issn else None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using "no." for ISSN is weird and makes it easy to confuse with issue. "ISSN: " would be a better label. Since ISSN isn't present in Zenodo it's not a change.

@tmorrell
Copy link
Contributor

tmorrell commented Aug 9, 2023

These are a good set of improvements, though I'm in favor of a complete rethink of the formatting in #1336 and #1305.

@jrcastro2
Copy link
Contributor Author

These are a good set of improvements, though I'm in favor of a complete rethink of the formatting in #1336 and #1305.

Pinging @slint who can possibly help on this.

@slint
Copy link
Member

slint commented Aug 10, 2023

These are a good set of improvements, though I'm in favor of a complete rethink of the formatting in #1336 and #1305.

The issue we're facing is that the format we had on Zenodo had already been agreed upon with some partners and users. I agree though that the changes in the mentioned PRs are more clear and extensive.

So the final decision is to actually merge #1336 and #1305, and make the formatting configurable (so that we can apply it on Zenodo and possibly communicate in the future that we're going to change to what InvenioRDM has).

@slint slint mentioned this pull request Sep 12, 2023
Closed
10 tasks
@kpsherva
Copy link
Contributor

kpsherva commented Oct 9, 2023

closed in favour of #1305

@kpsherva kpsherva closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmorrell tmorrell tmorrell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jrcastro2 @tmorrell @slint @kpsherva