-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deposit: check permission and set disable tooltip for publish button #1768
deposit: check permission and set disable tooltip for publish button #1768
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Thanks so much for keeping with this. It looks great.
...ssets/semantic-ui/js/invenio_rdm_records/src/deposit/controls/PublishButton/PublishButton.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
38526d2
to
4b3c7fb
Compare
...ssets/semantic-ui/js/invenio_rdm_records/src/deposit/controls/PublishButton/PublishButton.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please check the comment about responsive layout
...ssets/semantic-ui/js/invenio_rdm_records/src/deposit/controls/PublishButton/PublishButton.js
Outdated
Show resolved
Hide resolved
b31818f
to
cdc34cf
Compare
ping @rekt-hard could you please rebase? |
cdc34cf
to
9261e96
Compare
❤️ Thank you for your contribution!
Description
Check the
can_publish
permission to determine the rendering of the publish button on the front end.A tool tip will be shown on hover, when the publish button is disabled.
No permission:
Missing fields:
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: