Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deposit: check permission and set disable tooltip for publish button #1768

Merged

Conversation

rekt-hard
Copy link
Contributor

❤️ Thank you for your contribution!

Description

Check the can_publish permission to determine the rendering of the publish button on the front end.
A tool tip will be shown on hover, when the publish button is disabled.

No permission:
Screenshot from 2024-07-10 13-00-41

Missing fields:
Screenshot from 2024-07-10 13-07-16

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

Copy link
Contributor

@fenekku fenekku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks so much for keeping with this. It looks great.

Copy link
Member

@Samk13 Samk13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@kpsherva kpsherva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please check the comment about responsive layout

@rekt-hard rekt-hard force-pushed the deposit-publish-permission branch 2 times, most recently from b31818f to cdc34cf Compare July 22, 2024 15:15
@Samk13 Samk13 requested a review from ntarocco August 21, 2024 13:43
@max-moser
Copy link
Contributor

ping @rekt-hard could you please rebase?
then i'll merge

@max-moser max-moser merged commit ea9aceb into inveniosoftware:master Sep 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants