Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[on hold]cli: fix init force #190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[on hold]cli: fix init force #190

wants to merge 1 commit into from
+1 −1

Conversation

ppanero
Copy link
Member

@ppanero ppanero commented Nov 14, 2019

Changes:

Passes ignore_existing if --force is used. As per the create function, it will add 400:

        if ignore_existing and not ignore:
            ignore = [400]
        elif ignore_existing and 400 not in ignore:
            ignore.append(400)

Closes #189

@kpsherva kpsherva mentioned this pull request Nov 14, 2019
Closed
carantunes
carantunes approved these changes Nov 15, 2019
View reviewed changes
Copy link

@carantunes carantunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working 👍

@kpsherva kpsherva changed the title cli: fix init force [on hold]cli: fix init force Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzacharo zzacharo zzacharo approved these changes

@carantunes carantunes carantunes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cli: index init --force not working
3 participants
@ppanero @carantunes @zzacharo