Cython stubs #811
Merged
Cython stubs #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfmoraes
reviewed
Jul 30, 2024
tfmoraes
reviewed
Aug 4, 2024
|
In addition to the fixing the review comments above I have also deleted the following modules:
|
excluded listctrl from ruff Fixed ruff errors in canvas_renderer
changed font to graphics font to avoid type conflict
omar-abdelgawad
force-pushed
the
type-info-4
branch
from
7b7be9f to
dec7db9
Compare
tfmoraes
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Describe your changes
.pyistubs toinvesalius_cy.invesalius/data/bases.py,invesalius/data/converters.py,invesalius/data/poly_data_utils.py,invesalius/data/vtk_utils.py,invesalius/data/watershed_process.py,invesalius/session.py,invesalius/pubsub/pub.py, andinvesalius/gui/dialogs.py.wx._core.PyAssertionErrortowx.PyAssertionError.invesalius/control.py,invesalius/data/coordinates.invesalius/data/segmentation.py.pyclaronandoptitracktorequirements.txt.🗒️ Notes for future improvements
I am currently facing some issues with mypy since writing the stubs and am currently relying on Pyright through Pylance. I will make sure to fix the problem and make sure that a type checker tool run tests.