Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for mapSuccess and mapApiError #26

Merged
merged 7 commits into from
Sep 20, 2024
Merged

Add tests for mapSuccess and mapApiError #26

merged 7 commits into from
Sep 20, 2024

Conversation

vhontar
Copy link
Collaborator

@vhontar vhontar commented Sep 13, 2024 •
edited
Loading

#22
Followed by: #21

  1. Added tests for mapSuccess and mapApiError.
  2. Removed runCatching and use nullable ApiErrorBody?

@vhontar vhontar requested a review from StefMa September 13, 2024 15:22
StefMa
StefMa reviewed Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@StefMa StefMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
That looks nice 👏

Did you already verified that this code works within our project?
Is it possible to parse an nullable ApiErrorBody with failedResponse.body()? 🤔

Or is it just tested within tests?

library/src/commonTest/kotlin/com/ioki/passenger/api/Helpers.kt Outdated Show resolved Hide resolved
library/src/commonTest/kotlin/com/ioki/passenger/api/MapApiErrorTest.kt Show resolved Hide resolved
library/src/commonTest/kotlin/com/ioki/passenger/api/MapApiErrorTest.kt Outdated Show resolved Hide resolved
StefMa
StefMa approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@StefMa StefMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice!
Thanks for this 👏

@vhontar vhontar merged commit f81a8e3 into main Sep 20, 2024
7 checks passed
@vhontar vhontar deleted the 22_add_tests_mapSuccess_mapApiError branch September 20, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlh-ioki vlh-ioki vlh-ioki left review comments

@StefMa StefMa StefMa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vhontar @StefMa @vlh-ioki