fix layout bug and support pnpm #1760
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise will need to include `--shamefully-hoist` flag when installing with pnpm
|
also updated angular compiler to fix prod build error reference: angular/angular-cli#22606 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the tutorial page, there is swiper slides, however the default layout of swiper slides are using display flex (and default flex direction is row).
I changed the styling to state flex direction as column explicitly to restore the layout as in previous version's template.
Not sure why stating the style in tutorial.scss doesn't work, so I am stating the styles in app.scss.
Also, I state the dependencies on @ionic/core and ionicons explicitly to support installing with pnpm without
--shamefully-hoistflag.