chore(deps): upgrade to stencil 4 #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
approved these changes
Aug 22, 2023
| @@ -23,7 +23,7 @@ | |||
| "test.spec": "stencil test --spec" | |||
| }, | |||
There was a problem hiding this comment.
Do we want source map generation? This is enabled by default in Stencil 3. I recall there being some issues in Framework that made us disable it.
There was a problem hiding this comment.
Good call, I disabled it for the same reasoning we disabled it for PWA elements: ionic-team/pwa-elements#125
liamdebeasi
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1255
Upgrades the ionicons project to build with Stencil v4.