Skip to content
This repository has been archived by the owner on Sep 15, 2021. It is now read-only.

wikitude plugin properly added #1278

Open
wants to merge 2 commits into
base: dev-next
Choose a base branch
from

Conversation

yailPeralta
Copy link

No description provided.

@gortok
Copy link
Contributor

gortok commented Jun 28, 2016

Thanks for your work on this. One issue:

src/plugins/wikitudePlugin.js
  line 18  col 77  'success' is defined but never used.

Here's the full output:

[00:34:56] Using gulpfile ~/build/driftyco/ng-cordova/gulpfile.js
[00:34:56] Starting 'jshint'...
[00:34:56] Starting 'jscs'...
[00:34:56] Finished 'jscs' after 112 ms
src/plugins/wikitudePlugin.js
  line 18  col 77  'success' is defined but never used.
✖ 1 problem
[00:34:59] 'jshint' errored after 2.63 s
[00:34:59] Error in plugin 'gulp-jshint'
Message:
    JSHint failed for: src/plugins/wikitudePlugin.js
npm ERR! Test failed.  See above for more details.

You can use gulp jscs to run the style checker.

@yailPeralta
Copy link
Author

Jshint issue fixed

@yailPeralta yailPeralta reopened this Jun 29, 2016
@gortok
Copy link
Contributor

gortok commented Jun 29, 2016

Drop the dist/ng-cordova.js change and you'll be fine. Just remember when you build to have the commit ignore changes in the dist/* folders

@yailPeralta yailPeralta force-pushed the dev-next branch 2 times, most recently from 142a4ab to 3bc927a Compare July 1, 2016 20:52
@yailPeralta
Copy link
Author

yailPeralta commented Jul 1, 2016

Fixed up!
Regards.

@gortok
Copy link
Contributor

gortok commented Jul 6, 2016

The only remaining issue is that you shouldn't have any changes in the dist/* folders (reason being, that's an artifact folder and changes there are really hard to merge in; so we make changes there when we release).

@yailPeralta
Copy link
Author

@gortok sorry I forgot that part, is ready.

@gortok
Copy link
Contributor

gortok commented Jul 7, 2016

Unfortunately you can't just add the .gitignore to the dist/ folder, since we do rely on that folder; it's a build artifact that is used in master to allow for bower installs.

@yailPeralta
Copy link
Author

Ok sure, sorry about that, but how can i do it?

@gortok
Copy link
Contributor

gortok commented Jul 7, 2016

revert the files you changed in dist/ to their previous state (before you messed with them) http://stackoverflow.com/questions/215718/reset-or-revert-a-specific-file-to-a-specific-revision-using-git

@yailPeralta
Copy link
Author

Finally achieved, I hope ..

@gortok
Copy link
Contributor

gortok commented Aug 22, 2016

@yailPeralta Your commit still shows the dist change: https://github.com/driftyco/ng-cordova/pull/1278/files

Isn't Git fun?

Copy link
Contributor

@gortok gortok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the dist/* files from the commit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants