Skip to content
This repository has been archived by the owner on Sep 15, 2021. It is now read-only.

Added Windows Universal Platform Support (UWP) #1286

Open
wants to merge 1 commit into
base: dev-next
Choose a base branch
from

Conversation

timothystewart6
Copy link

@timothystewart6 timothystewart6 commented Jul 7, 2016

This supersedes #1258

Telling AppRate to use Windows 8 settings is a nice workaround, but we should create its own preference placeholder. I created a PR to add this setting in AppRate since it uses a different method for determining the Windows 10 platform.
pushandplay/cordova-plugin-apprate#120

For reference:

  • Added Windows support
  • ran gulp jscs no errors
  • ran gulp build
  • reverted changes to ./dist/*

@timothystewart6
Copy link
Author

Updated

@timothystewart6
Copy link
Author

@gortok I closed the other PR and opened this one against dev-next

@gortok
Copy link
Contributor

gortok commented Sep 13, 2016

Thanks; but please drop any files you changed in dist/*; those are build artifacts and shouldn't be included in a PR.

Copy link
Contributor

@gortok gortok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the dist/* files. Nothing that is after dist/* should be in the commit. Same with demo/*/dist/. All we need are the mocks/ and the src/plugin changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants