Skip to content
This repository has been archived by the owner on Sep 15, 2021. It is now read-only.

Google Analytics: API Update #1393

Open
wants to merge 1 commit into
base: dev-next
Choose a base branch
from

Conversation

cxaviousb
Copy link

The Google Analytics package that this project calls has been updated in a backwards incompatible manner. These edits are updates to address these changes.

This API clash is currently causing users of ng-cordova to be unable to log properly in Google Analytics after fresh builds.

Note:

  1. For an unknown reason (at least to me), a unit test is broken for $cordovaToast before I made any edits. Not sure what's causing it, but it should be pop up if retest your master branch as well.
  2. This contains the same edits as Google Analytics: API Update #1392 which is based off the master branch instead, given the current release doesn't work with the current release of https://github.com/danwilson/google-analytics-plugin

The Google Analytics package that this project calls has been updated in a backwards incompatible manner.  These edits are updates to address these changes.
@victorsosa
Copy link

victorsosa commented Apr 1, 2017

@gortok why this haven't been merge? this is needed change for ngCordova to work with GA. I am the maintainer of GA; I got a lot of issues related to this. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants