tools/opensnoop: Fix bad mode value #5205
Open
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rtoax
requested review from
brendangregg,
goldshtn and
davemarchevsky
as code owners
O_TMPFILE = 020200000 = __O_TMPFILE | O_DIRECTORY
If flag contains only O_DIRECTORY, the mode value is invalid. The mode value is
valid only when flag contains both __O_TMPFILE and O_DIRECTORY.
For example, 02204000 only contains __O_TMPFILE or O_DIRECTORY, will get bad
random mode value:
$ sudo ./opensnoop.py -e
PID COMM FD ERR FLAGS MODE PATH
1325 in:imjournal 108 0 02000101 146720225 /var/lib/rsyslog/imjournal.state.tmp
^
__O_TMPFILE
927848 cgroupify 5 0 02204000 22343344131 .
^
O_DIRECTORY
Fix: commit e80ad4d ("tools/opensnoop: Display mode for -e, --extended_fields (iovisor#5196)")
Signed-off-by: Rong Tao <[email protected]>
Rtoax
force-pushed
the
patch-79-tools-opensnoop-bugfix
branch
from
e6811b3 to
d82c3a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
O_TMPFILE = 020200000 = __O_TMPFILE | O_DIRECTORY
If flag contains only O_DIRECTORY, the mode value is invalid. The mode value is valid only when flag contains both __O_TMPFILE and O_DIRECTORY.
For example, 02204000 only contains __O_TMPFILE or O_DIRECTORY, will get bad random mode value:
Fix: commit e80ad4d ("tools/opensnoop: Display mode for -e, --extended_fields (#5196)")