Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Context Menu Behavior in Dropdown Component #2358

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

george-hub331
Copy link

Fixes #1617

Summary

This PR improves the context menu behavior while following the TypeScript migration guidelines. It ensures proper typing and modern React patterns while fixing the context menu functionality.

Changes

Context Menu Improvements

  • Ensured only one context menu is displayed at a time
  • Improved context menu event handling
  • Added Escape key handler to dismiss context menus
  • Prevent browser native context menu from coming up

TypeScript Migration

  • Converted updated files to TypeScript (.tsx)
  • Added proper TypeScript interfaces for all props
  • Removed PropTypes in favor of TypeScript interfaces
  • Used modern functional components with proper typing
  • Added proper event type definitions
  • Follows project's TypeScript guidelines

@george-hub331 george-hub331 requested a review from a team as a code owner March 30, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve context menu on breadcrumbs
1 participant