Decouple deps #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which should be moved to services.
By explicitly checking for boolean in JSON object without going through schema validation.
As many will be used both by services and clients.
Clients are the only users, and it avoids some extra dependencies in services.
So as to decouple reporting from the function itself. And define tqdm-based reporter right in command-line client.
Although this may be completely dropped later on.
|
This starts to be mature enough for a review. |
The old code failed to get a proper dtype from metadata to build the uninitialized dataset. Allow testing by adding such a dataset to example files.
ivilata
force-pushed
the
decouple-deps
branch
from
c3984a9
to
1647a5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is that the simple API should depend on very little libs external to Python (httpx, numpy and little else).
Still WIP.