[WIP] Native immutableset #11

gabbard · 2018-11-06T17:09:56Z

No description provided.

Closes #8

Allow immutableset to be built with iteration order given by sort key

Closes #10

Addresses #4

Closes #9

codecov · 2018-11-06T17:14:34Z

Codecov Report

Merging #11 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #11   +/-   ##
=======================================
  Coverage   91.13%   91.13%           
=======================================
  Files           7        7           
  Lines         564      564           
=======================================
  Hits          514      514           
  Misses         50       50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebd41ac...582412d. Read the comment docs.

Ryan Gabbard added 30 commits August 19, 2018 19:29

Initial commit

e3565fd

Initial commit of immutableset implementation

6f7782c

Note borrowing in README; .idea in .gitignore

8806654

Add some debugging code to try to track down segfault

7235f08

Remove autogen files from CLion

25fae09

Add len() to immutableset

53fa9c2

Add getitem, contains to ImmutableSet

57b5d99

Initial, imperfect repr for ImmutableSet

51711e5

Iteration over ImmutableSet

c9e898d

Adds builder for ImmutableSet

a9e197c

Add list of TODOs from Python version

3450422

Use a singleton for the empty immutableset

a8f12ba

str for ImmutableSet

dbc400a

non-working drafts of union, intersection

89d3c95

Add local development instructions

9c8aeeb

Add CMake directory to gitignore

57ab292

Switch to MIT license

a257b2d

Switch to MIT license

1cc293b

Allow immutableset to be built with iteration order given by sort key

dad006f

Closes #8

Merge pull request #14 from rgabbard/8-ordered-set-builder

d9b9303

Allow immutableset to be built with iteration order given by sort key

Fix memory leak with order_key

1d84c23

Properly intialize ImmutableSetBuilder type

53a4ef8

Closes #10

Simplify ImmutableSet traverse method

85cedd4

Add test that empty immutable set is a singleton

7b32917

Minimal unit test for equality

6ef57ea

Test add_all

07b906b

Incomplete, untested steps towards type stubs

c9a890d

Disable tests not yet expected to pass

596246d

Don't up refcount of builder on every internal add

51d13c7

Decrement reference to iterator

6dbdd3b

Ryan Gabbard added 16 commits August 28, 2018 19:30

Basic intersection works

7869ab8

Addresses #4

Basic difference support

84502ea

Corrects repr/str for ImmutableSet

936aa25

Closes #9

Import commented tests from VistaNlp

d75505a

Add empty, of, builder static methods to ImmutableSet

6b96d07

Switch tests to using static methods for initialiation

5ffe90b

Update type stubs for static methods

e943ebe

Add basic test

8c5c6ac

Return identical object when making an immutableset from an immutableset

ecf9640

Fix broken hash method on ImmutableSet

ad3cc86

Add test that ImmutableSet init cannot be called

cc89e5d

Tests type-error on non-iterable to ImmutableSet.of

56a9885

Adds additional tests

809f555

ImmutableSet supports pickling

2486614

Shift all C code to sub-directory to prepare to hop repos

c433000

Merge branch 'c-implementation-draft' into native-immutableset

582412d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Native immutableset #11

[WIP] Native immutableset #11

gabbard commented Nov 6, 2018

codecov bot commented Nov 6, 2018 •

edited

Loading

[WIP] Native immutableset #11

Are you sure you want to change the base?

[WIP] Native immutableset #11

Conversation

gabbard commented Nov 6, 2018

codecov bot commented Nov 6, 2018 • edited Loading

Codecov Report

codecov bot commented Nov 6, 2018 •

edited

Loading