Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies to latest versions #246

Merged
merged 3 commits into from
Feb 24, 2025
Merged

Bump dependencies to latest versions #246

merged 3 commits into from
Feb 24, 2025

Conversation

SweetVishnya
Copy link
Collaborator

No description provided.

@SweetVishnya
Copy link
Collaborator Author

SweetVishnya commented Feb 22, 2025

@anfedotoff, can you, please, verify that casr-core is still working?

Copy link

codecov bot commented Feb 22, 2025

Codecov Report

Attention: Patch coverage is 44.44444% with 15 lines in your changes missing coverage. Please review.

Project coverage is 66.39%. Comparing base (ff57afd) to head (ef9f530).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
casr/src/bin/casr-cli.rs 0.00% 7 Missing ⚠️
casr/src/bin/casr-core.rs 0.00% 7 Missing ⚠️
libcasr/src/execution_class.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #246   +/-   ##
=======================================
  Coverage   66.39%   66.39%           
=======================================
  Files          34       34           
  Lines        8200     8211   +11     
=======================================
+ Hits         5444     5452    +8     
- Misses       2756     2759    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SweetVishnya SweetVishnya requested a review from Avgor46 February 22, 2025 21:33
@anfedotoff
Copy link
Collaborator

@anfedotoff, can you, please, verify that casr-core is still working?

I checked, it works fine.

@@ -52,5 +52,5 @@ name = "casr-dojo"
required-features = ["dojo"]

[dev-dependencies]
lazy_static = "1.4"
lazy_static = "1.5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we replace this crate with LazyLock?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We agreed to do it in a separate PR

@SweetVishnya SweetVishnya merged commit 5c3d818 into master Feb 24, 2025
10 of 11 checks passed
@SweetVishnya SweetVishnya deleted the bump-deps branch February 24, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants