Fix CLI to work with DataChain new listing
#517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying datachain-documentation with
|
| Latest commit: |
620107d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bd29bab3.datachain-documentation.pages.dev |
| Branch Preview URL: | https://ilongin-318-use-datachain-li.datachain-documentation.pages.dev |
1 task
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #517 +/- ##
==========================================
- Coverage 87.39% 86.92% -0.48%
==========================================
Files 97 97
Lines 10197 10130 -67
Branches 1396 1383 -13
==========================================
- Hits 8912 8805 -107
- Misses 923 961 +38
- Partials 362 364 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ilongin
force-pushed
the
ilongin/318-use-datachain-listing-in-cli
branch
from
2339227
to
8138cd5
Compare
amritghimire
approved these changes
Oct 25, 2024
|
LGTM as long as it is tested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes all CLI methods to work with new listing of
DataChainby using.from_storage()method.Before, CLI was completely detached which means if you would do
datachain index, listing created by that command would be invisible byDataChainlib, and vice versa.Now, those are again "one" system.
Note: that this PR removes custom TTL set for listings to expire as we from now on don't utilize
Storagetable any more where we had ability to save this. Instead, we will always use constant TTL time. If this doesn't seem enough, we can think about where to put this and maybe take into account some alternatives (maybe having some global config etc.)Followups:
NodewithFile