-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
snap: use python 3.10 #199
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As advised by: ``` :: + snapcraftctl build :: Warning: use 'craftctl default' to execute the default step handler ```
``` + snapcraftctl build 2024-02-10T23:05:37.4935281Z :: Warning: use 'craftctl default' to execute the default step handler 2024-02-10T23:05:38.1299850Z :: 2024-02-10T23:05:38.1307785Z :: Users are encouraged to replace 'snapcraftctl' with 'craftctl' and use 2024-02-10T23:05:38.1309791Z :: 'CRAFT_*' environment variables in scriptlets when building snaps based 2024-02-10T23:05:38.1318541Z :: on core22. Please refer to the core22 migration guide for details. ```
This bug should've been fixed in core22 base.
30eae92
to
7f8071e
Compare
d8830fa
to
dd7bb87
Compare
efiop
commented
Feb 11, 2024
Comment on lines
-46
to
-49
curl -sSLO https://s3-us-east-2.amazonaws.com/dvc-public/dvc-test/openjdk-7u75-b13-linux-x64-18_dec_2014.tar.gz | ||
curl -sSLO https://s3-us-east-2.amazonaws.com/dvc-public/dvc-test/hadoop-2.7.2.tar.gz | ||
tar -xzf openjdk-7u75-b13-linux-x64-18_dec_2014.tar.gz -C $SNAPCRAFT_PART_INSTALL | ||
tar -xzf hadoop-2.7.2.tar.gz -C $SNAPCRAFT_PART_INSTALL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this even worked before. We didn't even make
it before. I'll run with what we have right now to save time.
efiop
added a commit
that referenced
this pull request
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer support 3.8 that core20 is using, so migrating to a newer version.