Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export ID of YouTube videos #184

Closed
wants to merge 1 commit into from
Closed

Conversation

GromNaN
Copy link
Contributor

@GromNaN GromNaN commented Nov 14, 2017

Instead of extracting the video ID from the URL, I find it more convenient to have it in the data returned by iframely.

@GromNaN
Copy link
Contributor Author

GromNaN commented Dec 14, 2017

Hello @nleush,

What do you think of this feature ?
It would be very convenient to have the media ID exposed when available.

@j0k3r
Copy link
Contributor

j0k3r commented Jan 16, 2018

Any news about that @nleush @iparamonau?

@iparamonau
Copy link
Member

iparamonau commented Jan 16, 2018

Hey guys @GromNaN @j0k3r

This PR is basically the same as the open issue in three-year-old #75. Our challenge remains the same - if we start doing something for one provider, we'd need to support and maintain it universally across entire network. Plus, explain to people how it should be used - and we have no clear understanding ourselves yet. Perhaps, you could describe your use case a bit?

In any case, id as the name is reserved for the use in the cloud - we'd need to come up with something else. Also, there's now a way to have private plugins (see CUSTOM_PLUGINS_PATH in example config) - perhaps, it'll be simpler to maintain if you simply put the commit in one more private plugin for YT's regexps that returns ID in getMeta: function (youtube_video_gdata)

@GromNaN
Copy link
Contributor Author

GromNaN commented Jan 17, 2018

To ensure unicity of the medias stored in the database, we have a couple of fields "platform" (ex youtube) and "platformId" (ex etDRmrB9Css) with an "unique constraint".

I realize that the " canonical" URL provided by iframely is already an unique identifier that contains both the platform name and the id of the media.

@GromNaN GromNaN closed this Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants