Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add release based containers #4763

Merged
merged 7 commits into from
Jul 10, 2024

Conversation

syeopite
Copy link
Member

@syeopite syeopite commented Jun 24, 2024

  • Changes the current master based container to use "master" tag instead of "latest" tag
  • Adds a new workflow to build a container on each new release which has the "latest" tag, and a tag based on the current released version.

Once this process is done, it should allow us to quickly merge PRs which passed the code-review but not the testing stage. Instead, the testing-stage can be pushed to when each release occurs.

@syeopite syeopite added need-code-review A crystal developper need to check if the code is correct. need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something labels Jun 24, 2024
@syeopite syeopite requested a review from unixfox June 24, 2024 18:51
@syeopite syeopite requested a review from a team as a code owner June 24, 2024 18:51
@iBicha
Copy link
Contributor

iBicha commented Jun 25, 2024

Changes the current master based container to use "master" tag instead of "latest" tag

stable might be more commonly used/understood. Or even production.
Very good initiative!

@syeopite
Copy link
Member Author

The release containers are tagged as "latest" as to ensure a smooth transition for instances.

As testing is being moved to per-release with this PR, instances should be using the release containers instead of the container built off master as to ensure instance stability.

@iBicha
Copy link
Contributor

iBicha commented Jun 25, 2024

The release containers are tagged as "latest" as to ensure a smooth transition for instances.

As testing is being moved to per-release with this PR, instances should be using the release containers instead of the container built off master as to ensure instance stability.

Fair enough, I take my comment back

@SamantazFox
Copy link
Member

Could you rename the two files to something in the odds of container-release and container-nightly (or whatever you see fit)? The two names are too similar, that's confusing!

.github/workflows/build-stable-container.yml Outdated Show resolved Hide resolved
.github/workflows/build-stable-container.yml Show resolved Hide resolved
.github/workflows/build-stable-container.yml Outdated Show resolved Hide resolved
@SamantazFox SamantazFox removed the need-code-review A crystal developper need to check if the code is correct. label Jul 3, 2024
@SamantazFox SamantazFox added ready and removed need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something labels Jul 9, 2024
@SamantazFox
Copy link
Member

Marking as ready as the only option to trigger that is to merge the code and publish a new tagged release.

@SamantazFox SamantazFox changed the title Add release based containers CI: Add release based containers Jul 10, 2024
@SamantazFox SamantazFox merged commit d135e5b into iv-org:master Jul 10, 2024
7 checks passed
@syeopite syeopite deleted the release-based-containers branch July 10, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants