use web screen embed for fixing potoken functionality #4923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unixfox
requested review from
syeopite and
SamantazFox
and removed request for
a team
This comment was marked as outdated.
This comment was marked as outdated.
unixfox
added a commit
that referenced
this pull request
Sep 16, 2024
This reverts commit de918b9. The code doesn't work as expected. Reverting
|
I reverted the commit. It doesn't work as expected. The issue being that WEB screen embed doesn't provide microformat info so this fails to work. Even WEB on a blocked IP doesn't provide it either so we will have to use next endpoint in order to fetch all the information that we previously extracted from microformat (description, publishedDate and more). |
|
Someone on matrix said that embed www.google.com does not work for all videos. Example for https://www.youtube.com/watch?v=0RyInjfgNc4 But it's a tradeoff until we can find a way to have WEB working again. |
|
@unixfox indeed, not all videos working on embed player. So i researched to find a working alternative.. please see it here LuanRT/YouTube.js#748 (comment) |
lumpsoid
pushed a commit
to lumpsoid/invidious
that referenced
this pull request
Nov 7, 2024
* use web screen embed for fixing potoken functionality * use web screen embed only for getting streamingData + disable tv screen on po_token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps for #4734
Since potoken is generated from a YouTube embed page, YouTube has started to enforce this token on exclusive usage of WEB_EMBEDDED_PLAYER client.
Thanks to
"embedUrl":"https://www.google.com/", this allows to have WEB_EMBEDDED_PLAYER working even on video that disallowed the embedding. As tested on https://www.youtube.com/watch?v=JfJYHfrOGgQI did found this parameter by entering the youtube video url on google.com and seeing that it worked there but not on the youtube embed page.
This also deactivates TVHTML5_SIMPLY_EMBEDDED_PLAYER when po_token is configured, since this doesn't work with that client.