Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace HOST_URL by Host header #5195

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

Fijxu
Copy link
Contributor

@Fijxu Fijxu commented Feb 28, 2025

Currently, each invidious process is fixed to it's domain config value which makes it really difficult for anyone to host Invidious using multiple domains, Tor and I2P.

If someone wants to host Invidious on Tor, a dedicated Invidious instance for it needs to be made setting domain to the Tor address, and the same goes for I2P.

On some places, HOST_URL is still used and it shouldn't be changed, like for example:

"hub.callback" => "#{HOST_URL}/feed/webhook/v1:#{time}:#{nonce}:#{OpenSSL::HMAC.hexdigest(:sha1, key, signature)}",

If this get merged when it's finished, it shouldn't break the setup of anyone using NGINX since the invidious documentation already mentions the use of the Host header on the NGINX configuration: https://github.com/iv-org/documentation/blob/65ecfccb10f15b4b9ce95c03b0d6d6ebd88bca7a/docs/nginx.md?plain=1#L24

Consider this a WIP since it's a big change that could break a lot of things, however, most of the changes made on the first commit are already applied to my Invidious fork at https://git.nadeko.net/Fijxu/invidious for a very very long time already, multiple domains works fine and Tor works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant