Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve issue #1497 (DesktopAssetManager is a misnomer) #1506

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Resolve issue #1497 (DesktopAssetManager is a misnomer) #1506

wants to merge 1 commit into from

Conversation

Ali-RS
Copy link
Member

@Ali-RS Ali-RS commented Apr 4, 2021 •
edited
Loading

Resolves #1497

@Ali-RS
Renamed DesktopAssetManager to DefaultAssetManager as it was a misnom…
b3195a3 
…er. It’s included in jme3-core and used both on desktop and mobile platforms.
@Ali-RS Ali-RS requested a review from stephengold April 4, 2021 17:53
@Ali-RS
Copy link
Member Author

Ali-RS commented Apr 4, 2021

@stephengold thanks for reviewing the PR.

@stephengold
Copy link
Member

Until #1497 is resolved, this should be marked as a "draft" PR.

@stephengold stephengold marked this pull request as draft April 4, 2021 23:34
@stephengold stephengold added this to the Future Release milestone Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengold stephengold stephengold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Future Release
Development

Successfully merging this pull request may close these issues.

DesktopAssetManager bad naming
2 participants
@Ali-RS @stephengold