This repository has been archived by the owner on Apr 4, 2021. It is now read-only.
Features #7
Open
Features #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed a lot on this. Added scrape feature to find numbers that are not links, added formatting of phone numbers to remove special characters and only send numbers. Added custom prefix function to allow setting prefix in options. Changed how phone numbers are stored. They are now assigned to the link created as it's class attribute so that there can be more than one on a page and it will not always send the last one stored in tel variable.
In order to sense clicks, added jquery in content scripts
In addition to IP address, can change password, protocol, whether to scrape for numbers, and prefix. May want to check formatting.
added pw, prot, scrape, and prefix options. Additional check for prefix to only allow number.
Removed chrome notification on end call, seemed unnecessary. Added password, protocol, scrap, and prefix variables. added Q5reload test to onMessage listener to save options immediately when save is clicked. Was having to relaunch chrome before. Added regex test before startCall.
Required for click sensing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added several things that I saw as issues. Options now lets you set IP address, password, protocol, dial prefix, and ability to scrape pages for phone numbers that are not formatted as achor tel elements. Changed the way that the number was being passed to the background so that it will correctlly handle situations where more than one number is present on a web site, and also added an immediate reload when save is clicked in the options page. Need to also add jquery, but I do not have push access, so it will not allow.