fix: jumbotron image positioned off-screen #1795
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviergoulet5
requested review from
ericpoirier,
chrisguindon and
ZacharySabourin
✅ Deploy Preview for jakartaee ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I'm only seeing a giant orange rectangle. Is that expected?
|
|
Nope. Not sure why I see the img locally. Let me check! |
|
@oliviergoulet5 Same for me, the image does not load. I suspect it's related to your class name change. @ZacharySabourin If you have time this week, can you take a look at fixing this MR? |
oliviergoulet5
force-pushed
the
fix-jumbotron-img
branch
from
b15a436
to
e8f1057
Compare
|
Reversed the class name change. |
chrisguindon
approved these changes
Mar 19, 2024
ericpoirier
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where bg-secondary jumbotron images are positioned off the screen at certain screen widths.