allow for Server/WireTx without Clone #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm generally okay with this, I'd probably wait to merge it though as it is a breaking change. |
|
Looks like CI is failing due to some examples and such needing the updated interface. You should be able to run these locally by just running |
Server was required to implement `Clone`. This is only needed by its `sender()` function which clones the transmit wire. This removes the hard requirement, implementing `sender()` only when the used `WireTx` is also `Clone`.
hvraven
force-pushed
the
server-non-clone
branch
from
65e6740 to
af4abe7
Compare
|
I made some releases on the main postcard crates, so I'm going to merge this and bump the versions. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server was required to implement
Clone. This is only needed by itssender()function which clones the transmit wire. This function is not needed by the library itself.Remove the hard requirement, implementing
sender()only when the usedWireTxis alsoClone.Still getting used to the code base, but it might be better to return a reference instead, allowing the caller to clone if needed.