Add hosting provider support (Provider)

[msaladna]

This pull adds support for hosting providers (API doc) on top of your existing code:

Usage would be something along these lines to create a new user and provision a zone under that account:

$api = new Cloudflare\Provider($providerkey);
$key = $api->create_user("[email protected]", "somepasswd")->user_key;
$api->zone_set($key, "somedomain.com", "mycname.somedomain.com");

• Also fixed User::change_email() - fix typo in local variable name

[jamesryanbell]

Hi

Thanks for this, just a couple of points that need addressing:

• The endpoint for the hosting API is different to the client API, https://api.cloudflare.com/host-gw.html, this would need to be factored into the package
• Is there a specific reason you are using Doctrine\Instantiator\Exception\InvalidArgumentException? This is included into the package as part of PHPUnit but that's only a dev requirement for testing purposes, anyone who installed the package without the dev dependencies would not get this.

Thanks,
James

[msaladna]

Not sure why PHPStorm settled on importing a reference from Doctrine...

Pushed the missing changes. I'll leave formatting and style considerations to you.

[andrewklau]

Is there anything holding up getting this merged? Happy to help, would like to use this.

[jamesryanbell]

I've set aside some time this weekend to review this and hopefully merge.

Thanks,
James

[jamesryanbell]

Just one small change to the authentication, once that's sorted I am happy to merge.

Thanks,
James

[jamesryanbell]

Given that the provider authentication method is only used with the Provider class, I feel it would be simpler to revert this method back and just add another condition to the if statement for 3 arguments being passed in.

Then in the provider constructor you can do this:

parent::__construct($key, null, 'host');

I know it's a bit of a workaround but it saves having variable such as $arg1, $arg2 etc.. and reduces the complexity of the conditions. It also means we aren't introducing the breaking change of the constructor requiring at least one argument.

[msaladna]

My argument to that is that the method signature now becomes ambiguous. Formal parameters are supposed to lend some insight as to what the method accepts and also work in conjunction with docblock commenting.

Not withholding, it also breaks reflection on the method. You'll get inconsistent results with what actually needs to be passed, e.g.

    class Foo
    {
        public function __construct() {
            $args = func_get_args();
            var_dump($args);
        }
    }

    $rfxn = new \ReflectionMethod('Foo', '__construct');
    var_dump($rfxn->getNumberOfRequiredParameters());

Alternatively, we can drop support for pre-PHP 5.6 and use the variadic notation, i.e. function foo(...$args) { ... }. Ultimately it's your project, so let me know the direction you want to proceed. That's just my two cents on the matter.

[jamesryanbell]

Hi

Just holding off on this now as CloudFlare have added a third parameter to their authentication methods: User Service Key (https://api.cloudflare.com/#endpoints). So I need to think about how this factors into this work.

Thanks,
James