add operation to abort multipart upload #784
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferhatelmas
reviewed
Apr 20, 2023
Comment on lines
+815
to
+819
| await ctx.store.abortUpload( | ||
| ctx.params.bucket, | ||
| ctx.params.key, | ||
| ctx.query.uploadId, | ||
| ctx.headers, |
There was a problem hiding this comment.
why to pass unused (key & headers) ?
ferhatelmas
reviewed
Apr 20, 2023
| ctx.query.uploadId, | ||
| ctx.headers, | ||
| ); | ||
| ctx.body = ''; |
|
@jamhall is it possible to make a release with this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noted missing operation to abort multipart upload. That operation does not have response, so it's very easy to implement.