Fix race condition when deleting files #789
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leontastic
reviewed
Jan 3, 2022
There was a problem hiding this comment.
@vlovich Thank you for your PR contribution.
I read the issue you filed and agree with your reasoning on the solution. I think you're missing a parts.pop() call, see my comment in my review.
Give it a test and let me know. I haven't touched npm in years but I can probably publish a release for this bugfix after it's merged.
| !readdirSync(path.join(bucketPath, ...parts)).length | ||
| ) { | ||
| await fs.rmdir(path.join(bucketPath, ...parts)); | ||
| parts.pop(); |
There was a problem hiding this comment.
I think you forgot to re-add this line. Otherwise empty parent directories don't get cleaned up. You actually included it in your example here: #788 (comment)
There was a problem hiding this comment.
Sorry for the delayed reply. I hadn't seen this. Good catch. I left the pop in there locally but somehow corrupted the patch when applying.
Gracefully handle multiple threads deleting an object at the same time. When two concurrent requests come in to delete the last two remaining objects in a given path, they'll be racing each other trying to delete and cause a spurious deletion failure for one of them. Fixes jamhall#788
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gracefully handle multiple threads deleting an object at the same time.
When two concurrent requests come in to delete the last two remaining
objects in a given path, they'll be racing each other trying to delete
and cause a spurious deletion failure for one of them.
Fixes #788