simplify and fix neuronjson fields processing #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DocSavage
requested review from
stuarteberg
and removed request for
stuarteberg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue noticed by @stuarteberg regarding incorrect behavior for the
neuronjsondatatype's/allendpoint when only selecting fields with_userandshow=userquery string:http://dvid-server/api/node/:master/segmentation_annotations/all?show=user&fields=type_user
http://dvid-server/api/node/:master/segmentation_annotations/all?show=user&fields=type_user,type
The first will only return a fraction of the second request. This error was caused by a bug in overly complicated code to handle the various options for returning neuronjson data. It was fixed by moving from a procedure that removed fields to one that added fields from stored data as needed.
With the added tests I was able to verify the bad behavior between the two types of requests.
This change is