fix: do not modify index.ejs with default viewport meta tag #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really like this pr 👍. Right now html-webpack-plugin 5 tries to introduce no breaking changes to stay aligned with webpack 5. Unfortunately this pr might break peoples sites.. |
jantimon
reviewed
Oct 24, 2021
|
This issue had no activity for at least half a year. It's subject to automatic issue closing if there is no activity in the next 15 days. |
Take into account `src/index.ejs` existence while deciding to add default meta-tags. Closes: jantimon#1387
Den-dp
force-pushed
the
fix/do-not-modify-index.ejs-with-default-meta-tag
branch
from
4cb3def
to
26a3704
Compare
|
I've rebased my PR just in case |
Sonny40
approved these changes
Aug 1, 2022
Sonny40
approved these changes
Aug 1, 2022
Sonny40
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take into account
src/index.ejsexistence while deciding to add default meta-tags.Closes: #1387