Kernel object improvements #162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://blogs.oracle.com/linux/post/whats-inside-a-linux-kernel-core-dump was invaluable to understand where to read the kernel ASLR offset from. Test Plan ========= Checked a couple of symbols on 3 different machines (Ubuntu, RHEL, Fedora) and the KASLR offset was calculated correctly. Everything worked on x86 and arm64 too.
javierhonduco
force-pushed
the
kernel-object-improvements
branch
from
d928f58 to
7c62d67
Compare
|
Fixes #116 |
rdelfin
approved these changes
Feb 19, 2025
| @@ -4,9 +4,17 @@ use std::fmt::Display; | |||
| use std::fmt::Formatter; | |||
| use std::str; | |||
|
|
|||
| use anyhow::Result; | |||
There was a problem hiding this comment.
(this is actually fine I just needed an excuse to use the gif)
| @@ -65,7 +58,7 @@ impl ObjectFile { | |||
|
|
|||
| /// Returns an identifier for the executable using the first 8 bytes of the build id. | |||
| pub fn id(&self) -> Result<ExecutableId> { | |||
| Ok(u64::from_ne_bytes(self.build_id.data[..8].try_into()?)) | |||
| self.build_id.id() | |||
Comment on lines
+75
to
+78
| let mut data = Vec::new(); | ||
| file.read_to_end(&mut data)?; | ||
|
|
||
| parse_gnu_build_id_from_notes(&data) |
There was a problem hiding this comment.
Looking at it, would it make sense to pass the reader directly to the parse_gnu_build_id_from_notes()? Or does the iterator not work on readers?
| let mut data = Vec::new(); | ||
| file.read_to_end(&mut data)?; | ||
|
|
||
| parse_gnu_build_id_from_notes(&data) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits but the general one
https://blogs.oracle.com/linux/post/whats-inside-a-linux-kernel-core-dump
was invaluable to understand where to read the kernel ASLR offset from.
Test Plan
Checked a couple of symbols on 3 different machines (Ubuntu, RHEL,
Fedora) and the KASLR offset was calculated correctly. Everything worked
on x86 and arm64 too.