Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: avatar group implement #177

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jingyuexing
Copy link

Continuous improvement

@netlify
Copy link

netlify bot commented May 18, 2023

Deploy Preview for anu-vue failed.

Name Link
🔨 Latest commit a2bedbb
🔍 Latest deploy log https://app.netlify.com/sites/anu-vue/deploys/6465d6a5f9ad580008174632

@jd-solanki
Copy link
Owner

Hi 👋🏻

At first, I thought we don't need this component but if we think of the future we might need a component for this.

I saw your other PRs and it looks like you don't follow our contribution guide and don't follow our coding pattern. Can you please take a look at it and if possible please update the PR?

Additionally, I recommend you first discuss the API for new component so you don't have to rewrite the code and plan accordingly.

@jingyuexing
Copy link
Author

Hi 👋🏻

At first, I thought we don't need this component but if we think of the future we might need a component for this.

I saw your other PRs and it looks like you don't follow our contribution guide and don't follow our coding pattern. Can you please take a look at it and if possible please update the PR?

Additionally, I recommend you first discuss the API for new component so you don't have to rewrite the code and plan accordingly.

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants