-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add 50xx links from Newegg, Bestbuy, and B&H #3200
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is my first time submitting a PR for this repo. Please let me know if there are any issues. |
jef
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is my first time submitting a PR for this repo. Please let me know if there are any issues.
Great addition! Thank you for your first contribution! I appreciate it 😁
alanbixby
added a commit
to alanbixby/streetmerchant
that referenced
this pull request
Jan 31, 2025
jef
pushed a commit
that referenced
this pull request
Jan 31, 2025
### Description - Retroactively adds `itemNumber` to the trackers in `newegg.ts` - this is leveraged by `realTimeInventoryLookup()` for API stock checks instead of a scraper based check - ie https://www.newegg.com/product/api/ProductRealtime?ItemNumber=14-137-915 - Fixes the missing link on the zotac amp extreme infinity 5080 - Removes the dead link for the newegg suprim soc 5090 - https://www.newegg.com/p/N82E16814137929 ; the correct link already existed at https://www.newegg.com/p/N82E16814137915 - Updates the series list for new models introduced via #3200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added additional links to 50xx series cards from Newegg, Bestbuy, and B&H. I also updated the Bestbuy
test:series
link to an item that is in stock.