fix: rickroll selector is broken for captcha test #3207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jef
reviewed
Jan 31, 2025
test/util.ts
Outdated
| @@ -39,7 +39,7 @@ export function getTestStore(): Store { | |||
| text: ['Rickrolling'], | |||
| }, | |||
| captchaHandler: { | |||
| challenge: 'img.thumbimage', | |||
| challenge: '#mw-content-text > div.mw-content-ltr.mw-parser-output > figure:nth-child(3) > a > img', | |||
There was a problem hiding this comment.
This type of selector can be inconsistent, but thank you for updating and bringing it to my attention.
Try to aim for a specific selector (like the previous one) to avoid unintended interactions with other elements on the page.
Suggested change
| challenge: '#mw-content-text > div.mw-content-ltr.mw-parser-output > figure:nth-child(3) > a > img', | |
| challenge: '.mw-file-element', |
|
That suggestion unfortunately does let the test pass, but it just sends a small image of a lock. I tried this less precise, but still successful, selector. |
|
#3213 was opened for this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the
npm run test:captchatest.The wikipedia has apparently changed the image class, such that img.thumbimage no longer selects anything on the page.
Testing
If you run the test it throws a timeout exception as it is today.
My testing consisted of inspecting the rick roll element, clicking copy selector, and pasting it to replace img.thumbimage, and then running the test.
I'm not a node expert, or a selector expert, so feel free to decline this and change it to something more efficient / less likely to break as this is a very specific selector replacement.
New dependencies
N/A