Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add chains integration #3660

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: add chains integration #3660

wants to merge 1 commit into from

Conversation

osamamagdy
Copy link
Member

No description provided.

@osamamagdy
Copy link
Member Author

/cc @ankitm123

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign tomhobson
You can assign the PR to them by writing /assign @tomhobson in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot
Copy link
Contributor

⭐ PR built and available in a preview jenkins-x-jx-docs-pr-3660 here

@ankitm123
Copy link
Member 

- ./tmp-website/v3/develop/supply-chain-security/index.html
--
  |   |   |   | *  internally linking to chains/, which does not exist (line 1469)
  |   |   |   | <a href="chains/">sign tekton artifacts using chains</a>
  |   |   |   | htmlproofer 3.8.0 \| Error:  HTML-Proofer found 1 failure!

@osamamagdy osamamagdy force-pushed the docs--add-chains-integration branch 2 times, most recently from 503592b to 6f4aa6b Compare October 7, 2022 20:45
@jenkins-x-bot
Copy link
Contributor

⭐ PR built and available in a preview jenkins-x-jx-docs-pr-3660 here

@osamamagdy
Copy link
Member Author

/test preview

@jenkins-x-bot
Copy link
Contributor

⭐ PR built and available in a preview jenkins-x-jx-docs-pr-3660 here

@sonarcloud
Copy link

sonarcloud bot commented Oct 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jenkins-x-bot
Copy link
Contributor

⭐ PR built and available in a preview jenkins-x-jx-docs-pr-3660 here

@ankitm123
Copy link
Member

/hold

babadofar
babadofar requested changes Nov 13, 2022
View reviewed changes
content/en/v3/develop/supply-chain-security/chains.md
- path: helmfiles/tekton-chains/helmfile.yaml
```

3. Add this line to the `./helmfile.yaml` of the cluster repo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

point 2 and 3 look very similar to me

content/en/v3/develop/supply-chain-security/chains.md
url: https://chainguard-dev.github.io/tekton-helm-charts/
releases:
- chart: tekton/tekton-chains
version: 0.2.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the version come from versionstream?

content/en/v3/develop/supply-chain-security/chains.md

5. Create a `./helmfiles/tekton-chains/jx-values.yaml` to include additional configurations to suit your use.

6. As a final step you need to generate your own encrypted x509 keypair and save it as a Kubernetes secret, install [cosign](https://github.com/sigstore/cosign) and run the following:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Save in jx namespace?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babadofar babadofar babadofar requested changes

@ankitm123 ankitm123 Awaiting requested review from ankitm123

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
do-not-merge/hold size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@osamamagdy @jenkins-x-bot @ankitm123 @babadofar