-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP JENKINS-57427 support warnings-ng plugin #221
base: master
Are you sure you want to change the base?
Conversation
@@ -63,7 +63,7 @@ | |||
workflow-step-api or workflow-api--> | |||
<junit-plugin.version>1.26.1</junit-plugin.version> | |||
<asm.version>5.2</asm.version> | |||
<workflow-support-plugin.version>2.22</workflow-support-plugin.version> | |||
<workflow-support-plugin.version>3.2</workflow-support-plugin.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can switch to BOM
|
||
xmlOutputDirectory = XmlUtils.getPathInWorkspace(xmlOutputDirectory, workspace); | ||
|
||
String spotBugsResultsFile = xmlOutputDirectory + "/spotbugsXml.xml"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this only supports SpotBugs so far, maybe better to reflect that in the PR title.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @jglick Yes I know. I also really want to do this integration and to remove deprecated dependencies. It is on my top level TODO list. For now, I only do bug fixing to discover the plugin internals, and next then I will work on this |
No description provided.