-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace chalk
with picocolors
#15487
Draft
pralkarz
wants to merge
39
commits into
jestjs:main
Choose a base branch
from
pralkarz:chalk-to-picocolors
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k-with-picocolors
…k-with-picocolors
…k-with-picocolors
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was referenced Feb 3, 2025
I've opened #15490 to make it easier to gauge what snapshot changes are needed to go forward with this migration. I think it's gonna be much more comfortable to review when done package-by-package rather than opening one huge PR with thousands of lines of snapshot changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With #15197 as a starting point, this PR completes the migration from
chalk
topicocolors
for most packages (the remaining ones use more advancedchalk
features not present inpicocolors
, e.g. Truecolor support). Failing tests are largely snapshots stemming from ANSI escape codes being put in different places by these two libraries, e.g.:Chalk seems to operate line-by-line, while
picocolors
sets the color once and clears it once. I could just update the snapshots, but that would result in a massive diff. What's the suggested course of action here? I could split this PR and go package-by-package instead, updating the snapshots as I go.Test plan
TBD.