Fix calledWith(objectContaining) when there are multiple calls #15508
+158
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#15038 introduced an issue (#15501) where
expect(fn).toHaveBeenCalledWith(expect.objectContaining(...))
would not work if the function was called multiple times, due to mutation of thesample
state after each non-matching call.This PR reverts the change and adds tests which will catch the issue if it's re-introduced.
Initially I thought I'd found a way to fix the issue and preserve the formatting improvements, but while adding tests, I found some cases where the failure messages were misleading (extra "expected" object properties shown that weren't originally present--example). I couldn't think of a way to fix that case without adding a new option to
pretty-format
, so it seemed best to just revert the change since correctness is more important than improved formatting.Test plan
Existing tests pass (one snapshot changed due to the revert). Added tests which would detect if this issue is re-introduced.
Fixes #15501