Add validation wrapper for PatternPrompt class #7447

captain-yossarian · 2018-12-02T15:03:50Z

Summary

Test plan

facebook-github-bot · 2018-12-02T15:03:57Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

captain-yossarian · 2018-12-02T15:10:32Z

@SimenB Can you please check the algorithm of my fix?
I had not add tests because I'm not sure if my code fit the jest code styleguide.

natealcedo · 2018-12-21T13:27:48Z

@SerhiiBilyk Are you still working on this? I'd still love this feature to be included. I keep fat fingering things in watch mode.

captain-yossarian · 2018-12-21T15:07:29Z

@natealcedo, I am waiting for review now

SimenB

Code LGTM, thanks! This is however missing tests and a changelog entry before we can merge 🙂

Also, could you post some screenshots for how this looks?

packages/jest-watcher/src/PatternPrompt.js

captain-yossarian · 2018-12-26T11:06:32Z

@SimenB @rickhanlonii @rogeliog screenshots:

captain-yossarian · 2019-01-20T13:03:35Z

@rickhanlonii @SimenB Can you please help me with testing?

SimenB

Please update the changelog.

When it comes to a test, you can add an integration test in https://github.com/facebook/jest/blob/64b3a9b72b8cba4bd303cc0c9f87d23645635936/e2e/__tests__/watchModePatterns.test.js

There you can see how patterns are provided 🙂 If you're willing, some unit tests would be great as well!

.vscode/settings.json

natealcedo · 2019-01-21T07:46:57Z

@SerhiiBilyk I would suggest just writing all the tests first and then asking for a review. If you are unsure on how to write tests you should take a look at the CONTRIBUTING.md. That way, reviewers can give feedback on all of your code at one go rather than waiting for a review before writing tests.

captain-yossarian · 2019-01-21T08:17:18Z

@natealcedo ok.

captain-yossarian · 2019-02-02T15:50:30Z

@SimenB @rickhanlonii
I've add e2e tests.
Like I understand , unit tests of PatternPrompt are in jest-cli/src/tests/watch_filename_pattern_mode.test.
But I don't know how to configure them.
I will appreciate for any help. Thank you

jeysal · 2019-02-02T16:15:09Z

Like I understand , unit tests of PatternPrompt are in jest-cli/src/tests/watch_filename_pattern_mode.test

Yes, and in watch_test_name_pattern_mode.test. You could for example copy the test case "Pressing P enters pattern mode" and modify it so that it types an invalid pattern and tries to press enter, and then assert that Jest does not try to rerun with the invalid pattern.

captain-yossarian · 2019-02-10T10:21:02Z

@jeysal thank you for your tip. Can you check please my unit test?

thymikee · 2019-02-10T10:26:14Z

btw, @SerhiiBilyk can you rebase your work to master? jest-watcher was recently converted to TypeScript

jeysal · 2019-02-10T10:38:42Z

@jeysal thank you for your tip. Can you check please my unit test?

Looking good, that's what I thought of 👍
As @thymikee said, the TypeScript migration unfortunately causes a few conflicts for existing PRs so you'll have to rebase, then we can give it a final review :)

package.json

SimenB · 2019-02-10T10:44:25Z

Don't worry too much about the conflict, we can resolve that ourselves before merging 🙂

captain-yossarian · 2019-02-10T11:26:04Z

@thymikee @jeysal @SimenB branch is rebased

packages/jest-cli/src/__tests__/watch_filename_pattern_mode.test.js

jeysal

LGTM if CI passes
Edit: and if you add a changelog entry as mentioned in @SimenB's review :)

jeysal · 2019-02-10T12:47:57Z

packages/jest-cli/src/__tests__/__snapshots__/watch_filename_pattern_mode.test.js.snap

@@ -90,6 +100,16 @@ Object {
 }
 `;

+exports[`Watch mode flows Pressing "P" enters pattern mode and invalid regexp 1`] = `


This snapshot seems obsolete?

thymikee · 2019-02-10T13:05:49Z

packages/jest-watcher/src/lib/Prompt.ts

@@ -39,7 +39,7 @@ export default class Prompt {

  enter(
    onChange: (pattern: string, options: ScrollOptions) => void,
-    onSuccess: () => void,
+    onSuccess: (pattern: string) => void,
    onCancel: () => void,


onCancel has different fn signature than https://github.com/facebook/jest/pull/7447/files?w=1#diff-048f6a2e1f2d542739b5b37c81a7e9c3R16, I think it's still should be _onCancel: (value?: string) => void

We initialize to empty string, so the correct type is that it's passed. right?

captain-yossarian · 2019-07-15T20:19:56Z

Is it still relevant ?

SimenB · 2019-07-15T21:25:33Z

Yeah, I'd say so! Would you mind rebasing?

rogeliog · 2019-07-18T16:15:24Z

I agree, this is still relevant

* removed default value of prettierPath from argv * updated snapshot for show_config * updated changelog * fixed wrong package name in changelog

* (fix) message should return a function message should return a function and not a constant * Update CHANGELOG.md

* Update CHANGELOG formatting * Dedupe

)

* Migrate jest-changed-files to Typescript * Add changelog entry * Update e2e/__tests__/jestChangedFiles.test.js Co-Authored-By: loryman <[email protected]> * Stricter typings Merge remote-tracking branch 'origin/jest-changed-files-typescript' into jest-changed-files-typescript * Make prettier happy

## Summary It doesn't make sense to wrap a `runJust` call into `stripAnsi` since the latter works only with strings. `runJest` returns an object so stripAnsi just passes it along. Materials: - Commit where the code was added in the first place: jestjs@e12cab6#diff-4cf7d6c79ff377b63522b3af20e34e8eR307 - stripAnsi source code: https://github.com/chalk/strip-ansi/blob/097894423fedb6b4dca3005ad45608b893fcdcf8/index.js

* chore: migrate jest-matcher-util to TypeScript * link to PR * unknown and fix flow

captain-yossarian · 2019-07-24T18:19:54Z

@SimenB @thymikee Sorry, but I will have no time to do thi PR until September. So, feel free to reassign this PR to other people

github-actions · 2022-09-08T18:57:20Z

This PR is stale because it has been open 1 year with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions · 2022-10-08T19:06:14Z

This PR was closed because it has been stalled for 30 days with no activity. Please open a new PR if the issue is still relevant, linking to this one.

github-actions · 2022-11-08T00:10:19Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

SimenB requested review from rogeliog and rickhanlonii December 2, 2018 20:08

SimenB requested changes Dec 24, 2018

View reviewed changes

packages/jest-watcher/src/PatternPrompt.js Outdated Show resolved Hide resolved

SimenB requested changes Jan 20, 2019

View reviewed changes

.vscode/settings.json Outdated Show resolved Hide resolved

SimenB reviewed Feb 10, 2019

View reviewed changes

package.json Outdated Show resolved Hide resolved

jeysal reviewed Feb 10, 2019

View reviewed changes

packages/jest-cli/src/__tests__/watch_filename_pattern_mode.test.js Show resolved Hide resolved

jeysal approved these changes Feb 10, 2019

View reviewed changes

thymikee reviewed Feb 10, 2019

View reviewed changes

H1Gdev and others added 4 commits July 18, 2019 18:48

Fix typo in docs. (jestjs#7414)

aa55a95

Fix: prettierPath not working via config file (jestjs#7412)

823dca3

* removed default value of prettierPath from argv * updated snapshot for show_config * updated changelog * fixed wrong package name in changelog

Fix Custom Matchers API example message property (jestjs#7426)

78f48ef

* (fix) message should return a function message should return a function and not a constant * Update CHANGELOG.md

Update CHANGELOG formatting (jestjs#7429)

6d4fe25

* Update CHANGELOG formatting * Dedupe

SimenB and others added 22 commits July 18, 2019 18:48

chore: correct type errors in leak-detector unit test

41caa76

chore: bump typescript eslint parser

a120a43

Refactor -o & --coverage implementation | Fixes jestjs#6859 (jestjs#7611

fdf0010

)

chore: remove cyclic dev dep on jest-diff from pretty-format

58ef82e

chore: migrate jest-matcher-util to TypeScript (jestjs#7835)

85bc5ee

* chore: migrate jest-matcher-util to TypeScript * link to PR * unknown and fix flow

chore: migrate jest-docblock to TypeScript (jestjs#7836)

3e8aabd

chore: migrate jest-serializer to TypeScript (jestjs#7841)

9ad1bed

chore: migrate jest-message-util to TypeScript (jestjs#7834)

19322c9

chore: migrate jest-util to TypeScript (jestjs#7844)

a714205

chore: migrate jest-watcher to TypeScript (jestjs#7843)

6f6eb9e

Add unit test

f8a35e4

Update packages.json and name of unit test

d6b4c0d

Add validation wrapper for onSuccess method

45a15e6

Move _pipe.write inside [else] branch

e80fdde

Add e2e test

bc2b2ad

Add unit test

0e02a61

Update packages.json and name of unit test

fa46631

Snapshot replace

87c1478

chore: migrate jest-mock to TypeScript (jestjs#7847)

f86395d

cleanup types

f459c7a

captain-yossarian force-pushed the bugfix/7382 branch from 59a33aa to f459c7a Compare July 18, 2019 16:52

github-actions bot added the Stale label Sep 8, 2022

github-actions bot closed this Oct 8, 2022

github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add validation wrapper for PatternPrompt class #7447

Add validation wrapper for PatternPrompt class #7447

captain-yossarian commented Dec 2, 2018 •

edited

Loading

facebook-github-bot commented Dec 2, 2018

captain-yossarian commented Dec 2, 2018 •

edited

Loading

natealcedo commented Dec 21, 2018

captain-yossarian commented Dec 21, 2018

SimenB left a comment

captain-yossarian commented Dec 26, 2018

captain-yossarian commented Jan 20, 2019

SimenB left a comment •

edited

Loading

natealcedo commented Jan 21, 2019

captain-yossarian commented Jan 21, 2019

captain-yossarian commented Feb 2, 2019

jeysal commented Feb 2, 2019 •

edited

Loading

captain-yossarian commented Feb 10, 2019

thymikee commented Feb 10, 2019

jeysal commented Feb 10, 2019

SimenB commented Feb 10, 2019

captain-yossarian commented Feb 10, 2019

jeysal left a comment •

edited

Loading

jeysal Feb 10, 2019

captain-yossarian Feb 10, 2019

thymikee Feb 10, 2019 •

edited

Loading

SimenB Feb 10, 2019

captain-yossarian commented Jul 15, 2019

SimenB commented Jul 15, 2019

rogeliog commented Jul 18, 2019

captain-yossarian commented Jul 24, 2019

github-actions bot commented Sep 8, 2022

github-actions bot commented Oct 8, 2022

github-actions bot commented Nov 8, 2022

Add validation wrapper for PatternPrompt class #7447

Add validation wrapper for PatternPrompt class #7447

Conversation

captain-yossarian commented Dec 2, 2018 • edited Loading

Summary

Test plan

facebook-github-bot commented Dec 2, 2018

captain-yossarian commented Dec 2, 2018 • edited Loading

natealcedo commented Dec 21, 2018

captain-yossarian commented Dec 21, 2018

SimenB left a comment

Choose a reason for hiding this comment

captain-yossarian commented Dec 26, 2018

captain-yossarian commented Jan 20, 2019

SimenB left a comment • edited Loading

Choose a reason for hiding this comment

natealcedo commented Jan 21, 2019

captain-yossarian commented Jan 21, 2019

captain-yossarian commented Feb 2, 2019

jeysal commented Feb 2, 2019 • edited Loading

captain-yossarian commented Feb 10, 2019

thymikee commented Feb 10, 2019

jeysal commented Feb 10, 2019

SimenB commented Feb 10, 2019

captain-yossarian commented Feb 10, 2019

jeysal left a comment • edited Loading

Choose a reason for hiding this comment

jeysal Feb 10, 2019

Choose a reason for hiding this comment

captain-yossarian Feb 10, 2019

Choose a reason for hiding this comment

thymikee Feb 10, 2019 • edited Loading

Choose a reason for hiding this comment

SimenB Feb 10, 2019

Choose a reason for hiding this comment

captain-yossarian commented Jul 15, 2019

SimenB commented Jul 15, 2019

rogeliog commented Jul 18, 2019

captain-yossarian commented Jul 24, 2019

github-actions bot commented Sep 8, 2022

github-actions bot commented Oct 8, 2022

github-actions bot commented Nov 8, 2022

captain-yossarian commented Dec 2, 2018 •

edited

Loading

captain-yossarian commented Dec 2, 2018 •

edited

Loading

SimenB left a comment •

edited

Loading

jeysal commented Feb 2, 2019 •

edited

Loading

jeysal left a comment •

edited

Loading

thymikee Feb 10, 2019 •

edited

Loading