Expose the real mysqld exit code to process-compose, so it can report any errors. Fixes #2518 #2519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… any errors. As a side-effect, removes $MYSQL_PID. Fixes jetify-com#2518. The old code used shell '&' to background mysqld, then captured its pid with MYSQL_PID=$!, in doing so obscuring the mysqld exit code. I can't see any sane way of both propagating the exit code *and* setting MYSQL_PID. I also can't see any point in MYSQL_PID, given that process-compose is a TUI and the pid is readily available in $MYSQL_PID_FILE. So to fix the bug, I've made mysqld no longer backgrounded (is_daemon becomes 'false').
… any errors. As a side-effect, removes $MYSQL_PID. Fixes jetify-com#2518. The old code used shell '&' to background mysqld, then captured its pid with MYSQL_PID=$!, in doing so obscuring the mysqld exit code. I can't see any sane way of both propagating the exit code *and* setting MYSQL_PID. I also can't see any point in MYSQL_PID, given that process-compose is a TUI and the pid is readily available in $MYSQL_PID_FILE. So to fix the bug, I've made mysqld no longer backgrounded (is_daemon becomes 'false').
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The old code used shell '&' to background mysqld, then captured its pid with MYSQL_PID=$!, in doing so obscuring the mysqld exit code.
I can't see any sane way of both propagating the exit code and setting MYSQL_PID. I also can't see any point in MYSQL_PID, given that process-compose is a TUI and the pid is readily available in $MYSQL_PID_FILE. So to fix the bug, I've made mysqld no longer backgrounded (hence
is_daemonbecomes 'false').How was it tested?
Testing is as in the description of #2518: set up mysqld to fail (e.g. claim port 3306) and
devbox services up.The mysqld process ought to go into a failure loop, toggling between status 'Restarting' and 'Running' and setting exit code 1.
(It's not related to this patch, but I suggest also limiting these infinite restarts by setting
max_restarts, e.g.:)