Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitLab - Corrected "Closed" status value in UpdatePullRequest #125

Merged
merged 1 commit into from
Dec 4, 2023
Merged

GitLab - Corrected "Closed" status value in UpdatePullRequest #125

merged 1 commit into from
Dec 4, 2023

Conversation

omerzi
Copy link
Member

@omerzi omerzi commented Dec 4, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used go fmt ./... for formatting the code before submitting the pull request.
  • This feature is included on all supported VCS providers - GitHub, Bitbucket cloud, Bitbucket server, GitLab and Azure Repos.
  • I added the relevant documentation for the new feature.
  • Updated the close merge request value in UpdatePullRequest to "close" instead of "closed".

@omerzi omerzi added the bug Something isn't working label Dec 4, 2023
@omerzi omerzi requested a review from attiasas December 4, 2023 06:53
@omerzi omerzi merged commit 9fe7a41 into jfrog:master Dec 4, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi approved these changes

@attiasas attiasas Awaiting requested review from attiasas

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omerzi @yahavi