Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean code: remove unused function #28387

Merged
merged 1 commit into from
Jan 5, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 1 addition & 77 deletions generators/base-application/support/task-type-inference.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,89 +17,25 @@
import type { ApplicationType } from '../../../lib/types/application/application.js';
import type { TaskTypes } from '../../../lib/types/application/tasks.js';
import type CoreGenerator from '../../base-core/generator.js';
import type { WriteFileBlock, WriteFileSection } from '../../base/api.js';
import type { WriteFileSection } from '../../base/api.js';
import type { Entity } from '../../../lib/types/application/entity.js';

export function asWriteFilesSection<Data = ApplicationType<Entity>>(section: WriteFileSection<Data>) {
return section;
}

export function asWriteFilesBlock<Data = ApplicationType<Entity>>(section: WriteFileBlock<Data>) {
return section;
}

export function asInitializingTask<E = Entity, A = ApplicationType<E>, const G extends CoreGenerator = CoreGenerator>(
task: (this: G, params: TaskTypes<E, A>['InitializingTaskParam']) => void,
) {
return task;
}

export function asPromptingTask<E = Entity, A = ApplicationType<E>, const G extends CoreGenerator = CoreGenerator>(
task: (this: G, params: TaskTypes<E, A>['PromptingTaskParam']) => void,
) {
return task;
}

export function asConfiguringTask<E = Entity, A = ApplicationType<E>, const G extends CoreGenerator = CoreGenerator>(
task: (this: G, params: TaskTypes<E, A>['ConfiguringTaskParam']) => void,
) {
return task;
}

export function asComposingTask<E = Entity, A = ApplicationType<E>, const G extends CoreGenerator = CoreGenerator>(
task: (this: G, params: TaskTypes<E, A>['ComposingTaskParam']) => void,
) {
return task;
}

export function asLoadingTask<E = Entity, A = ApplicationType<E>, const G extends CoreGenerator = CoreGenerator>(
task: (this: G, params: TaskTypes<E, A>['LoadingTaskParam']) => void,
) {
return task;
}

export function asPreparingTask<E = Entity, A = ApplicationType<E>, const G extends CoreGenerator = CoreGenerator>(
task: (this: G, params: TaskTypes<E, A>['PreparingTaskParam']) => void,
) {
return task;
}

export function asPostPreparingTask<E = Entity, A = ApplicationType<E>, const G extends CoreGenerator = CoreGenerator>(
task: (this: G, params: TaskTypes<E, A>['PostPreparingTaskParam']) => void,
) {
return task;
}

export function asPreparingEachEntityTask<E = Entity, A = ApplicationType<E>, const G extends CoreGenerator = CoreGenerator>(
task: (this: G, params: TaskTypes<E, A>['PreparingEachEntityTaskParam']) => void,
) {
return task;
}

export function asPreparingEachEntityFieldTask<E = Entity, A = ApplicationType<E>, const G extends CoreGenerator = CoreGenerator>(
task: (this: G, params: TaskTypes<E, A>['PreparingEachEntityFieldTaskParam']) => void,
) {
return task;
}

export function asPreparingEachEntityRelationshipTask<E = Entity, A = ApplicationType<E>, const G extends CoreGenerator = CoreGenerator>(
task: (this: G, params: TaskTypes<E, A>['PreparingEachEntityRelationshipTaskParam']) => void,
) {
return task;
}

export function asPostPreparingEachEntityTask<E = Entity, A = ApplicationType<E>, const G extends CoreGenerator = CoreGenerator>(
task: (this: G, params: TaskTypes<E, A>['PostPreparingEachEntityTaskParam']) => void,
) {
return task;
}

export function asDefaultTask<E = Entity, A = ApplicationType<E>, const G extends CoreGenerator = CoreGenerator>(
task: (this: G, params: TaskTypes<E, A>['DefaultTaskParam']) => void,
) {
return task;
}

export function asWritingTask<E = Entity, A = ApplicationType<E>, const G extends CoreGenerator = CoreGenerator>(
task: (this: G, params: TaskTypes<E, A>['WritingTaskParam']) => void,
) {
Expand All @@ -123,15 +59,3 @@ export function asPostWritingEntitiesTask<E = Entity, A = ApplicationType<E>, co
) {
return task;
}

export function asInstallTask<E = Entity, A = ApplicationType<E>, const G extends CoreGenerator = CoreGenerator>(
task: (this: G, params: TaskTypes<E, A>['InstallTaskParam']) => void,
) {
return task;
}

export function asEndTask<E = Entity, A = ApplicationType<E>, const G extends CoreGenerator = CoreGenerator>(
task: (this: G, params: TaskTypes<E, A>['EndTaskParam']) => void,
) {
return task;
}
7 changes: 0 additions & 7 deletions generators/base/support/secret.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,3 @@ export function createBase64Secret(len?: number | boolean, reproducible = false)
}
return Buffer.from(createSecret(len)).toString('base64');
}

/**
* Create a strong secret from a timestamp and a base name
*/
export function createSafeSecret(timestamp: number, baseName: string) {
return Buffer.from(`${timestamp}-${baseName}`).toString('base64');
}
2 changes: 1 addition & 1 deletion generators/bootstrap-application-base/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const { CASSANDRA } = databaseTypes;
const { OAUTH2 } = authenticationTypes;
const { CommonDBTypes } = fieldTypes;

const { STRING: TYPE_STRING, BOOLEAN: TYPE_BOOLEAN, INSTANT } = CommonDBTypes;
const { STRING: TYPE_STRING, BOOLEAN: TYPE_BOOLEAN } = CommonDBTypes;

const authorityEntityName = 'Authority';

Expand Down
Loading