Make libcitygml prebuilds portable #98
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If these are public libraries a client build system needs to link to them again even libcitygml was compiled into a self-contained dynamic library.
|
I just realized that now the citygml.pc file doesn't get installed correctly anymore. I'll fix that but probably it'll take me some time. Ok... I realized that it's much easier than I thought - already pushed the new version. |
gostefan
force-pushed
the
makePortable
branch
from
1045a00
to
38734e9
Compare
|
The first commit introduced a regression on linux. The CMake files weren't installed in the |
CMake's install will combine the relative path with the absolute path passed via CMAKE_INSTALL_PREFIX. This shouldn't be handled in CMakeLists.txt files. The state before resulted in absolute paths being used in citygmlConfig.cmake. That prohibits prebuilding the library and deploying it on other machines/paths.
It's unclear why the lib install folders worked without this before. But now the CMake files get correctly installed.
gostefan
force-pushed
the
makePortable
branch
from
4121de4
to
4af02e5
Compare
|
Trying to use the built project on Linux made me realize that the cmake files still had some absolute paths in them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current state of the CMakeLists.txt doesn't allow libcitygml to be prebuilt and deployed on different machines or to different paths.
With some simple fixes we can enable this usecase.
This PR is only about the last two commits - the three previous commits are part a different PR. But the changes would conflict if not based on each other.
If I should rather modify this PR to only include the last two commits, please let me know.