Fix connection hangs #78
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note how sendCmd inserts "None" instead of proper futures if waitForResponse=False. We need to safeguard against that. Otherwise, an exception will be raised when attempting to cancel "None", and then we will not successfully stop, and not properly reconnect either.
trigger a call-back to responseReceived. Thus, it's import to do any internal accounting, in particular on self._out_pending, before that call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #77 by fixing a few bugs that I discovered (after adding a lot of custom logging to identify the root cause). It also adds a recovery mechanism if no response for a message is received within a minute.