Removed unneeded dependency over YAML v3 #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jamesls do you have thoughts on this? From my eyes it looks ready to land. I would love to see this land to clean up some dependencies (it would also help to update go.mod to 1.17+ before the next release for the changes that triggers in dependency management) |
|
👋 @jamesls I want to check in - is there anything I can do to help get this merged and included in a release? |
|
@jehiah I suggest you look at the JmesPath Community-maintained port of this library. It includes this PR, up-to-date dependencies and many more improvements while staying - for all practical purposes - compatible with this library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70.
Fixes #71.
This PR removes the embedded internal copy of Testify and relies on the original package instead. By upgrading to a newer version of the package, the YAML v2 vulnerable dependency is no longer needed.