some minor performance improvements for LinkingUtil. improve logging for CdgPass #5232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpollmeier
reviewed
Jan 17, 2025
| @@ -22,6 +22,8 @@ import org.slf4j.{Logger, LoggerFactory} | |||
| class CdgPass(cpg: Cpg) extends ForkJoinParallelCpgPass[Method](cpg) { | |||
| import CdgPass.logger | |||
|
|
|||
| val hasLogged = java.util.concurrent.atomic.AtomicInteger(10) | |||
There was a problem hiding this comment.
please add a comment why you chose 10..
There was a problem hiding this comment.
I don't particularly care about the precise number -- it's just that, if a graph is broken in a way that triggers this log message often, then it tends to trigger this message very often, which takes forever (and spams the logs).
There was a problem hiding this comment.
Makes sense, and I was aware that 10 is just an arbitrary number, but whenever the next reader sees an arbitrary number they might wonder 'why that number', so a short comment is helpful IMO
...rontends/x2cpg/src/main/scala/io/joern/x2cpg/passes/controlflow/codepencegraph/CdgPass.scala
Outdated
Show resolved
Hide resolved
...rontends/x2cpg/src/main/scala/io/joern/x2cpg/passes/controlflow/codepencegraph/CdgPass.scala
Outdated
Show resolved
Hide resolved
…/controlflow/codepencegraph/CdgPass.scala Co-authored-by: Michael Pollmeier <[email protected]>
mpollmeier
reviewed
Jan 17, 2025
...rontends/x2cpg/src/main/scala/io/joern/x2cpg/passes/controlflow/codepencegraph/CdgPass.scala
Outdated
Show resolved
Hide resolved
…/controlflow/codepencegraph/CdgPass.scala Co-authored-by: Michael Pollmeier <[email protected]>
mpollmeier
approved these changes
Jan 22, 2025
...rontends/x2cpg/src/main/scala/io/joern/x2cpg/passes/controlflow/codepencegraph/CdgPass.scala
Show resolved
Hide resolved
…/controlflow/codepencegraph/CdgPass.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.