Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LSP rename converts next word if located in a non word character #114

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

johmsalas
Copy link
Owner

closes #113

peterfication
peterfication previously approved these changes Dec 15, 2023
Copy link
Collaborator

@peterfication peterfication left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work :) And good simple test cases for it :)

@@ -243,6 +243,21 @@ function utils.trim_str(str, _trimmable_chars)
return trim_info, trimmed_str
end

function utils.get_current_word_info()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to have this method documented on a high level what it does.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johmsalas johmsalas merged commit 2567488 into main Dec 15, 2023
6 checks passed
@johmsalas johmsalas deleted the issue-113 branch December 15, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LSP Renaming applies changes to the next adjacent word to the previous word
2 participants