chore: Upgrade from deprecated buf_request to buf_request_all for LSP #115
Conversation
| total_files = vim.tbl_count(response.result.changes) | ||
| end | ||
| end | ||
| print(string.format("Changed %s file%s. To save them run ':wa'", total_files, total_files > 1 and "s" or "")) |
There was a problem hiding this comment.
Maybe we can only print something if it changed more than one file? For one file, I wouldn't care if it's saved or not as I'm working on that specific file anyways right now.
Also, a prefix might be helpful e.g. "Textcase: Changed ..."
There was a problem hiding this comment.
Now that I think about it again, even a message for a single would be interesting because it gives feedback that the LSP rename worked.
There was a problem hiding this comment.
That's the reason for this comment.
There is currently a bug when multiple clients do textDocument/rename, the solution for this will be, given the nature of textDocument/rename it should only apply one of the clients, not all of them, I'll add some logic to chose one of the clients in the next PR
I didn't include it in this PR to separate the deliveries into small chunks, but in fact, I wouldn't have prioritized buf_request_all into the first milestone if it wasn't part of the solution to the multi LSP clients issue
There was a problem hiding this comment.
@peterfication by the way, I removed my assignment for #107 because I know you like to learn and might be interested on the final piece of this fix. Let me know otherwise or assign it to me directly :)
I've considered as a tech approach to iterate the list of results, find the one having the biggest amount of changes. In theory, all of them should provide exactly the same amount of changes, but just to be safe I'd still find the client that found the biggest amount. Then apply textDocument/rename using that client
There was a problem hiding this comment.
Alright, thanks for the explanation :)
I would really like to dive into #107
| -- after the edits are applied, the files are not saved automatically. | ||
| -- let's remind ourselves to save those... | ||
| -- TODO: This will be modified to include only one of the clients count | ||
| total_files = vim.tbl_count(response.result.changes) |
There was a problem hiding this comment.
I don't fully understand this line. Wouldn't it make sense to add up all the counts?
closes #57